send AUTH message if sentinel password is set#2154
Merged
sazzad16 merged 7 commits intoredis:masterfrom Apr 14, 2020
Merged
Conversation
Contributor
|
@kkolanow There are several errors in |
Contributor
Author
|
this time is fails on SetCommandsTest. I'm afraid I'm not sure what this test is supposed to do. Any help appreciated. Thanks! |
sazzad16
suggested changes
Feb 28, 2020
Contributor
There was a problem hiding this comment.
Only the first constructor can be added for user's convenience. Instead of using other new constructors, a user directly use the last constructor with all the params.
Also, don't do format only changes that are in distant lines from intended changes.
sazzad16
suggested changes
Feb 28, 2020
code review update Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
code review update Co-Authored-By: M Sazzadul Hoque <sazzad16@users.noreply.github.com>
sazzad16
approved these changes
Feb 29, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've noticed that during connection to the password protected sentinel (assume that master, replica slaves and sentinels share same password) I was getting error NOAUTH Authorization required. I discovered that sentinel password was not passed on. I'm submitting a fix example . I've tried it and it worked for me.